lidavidm commented on code in PR #2738:
URL: https://github.com/apache/arrow-adbc/pull/2738#discussion_r2059363952
##########
c/driver/common/CMakeLists.txt:
##########
@@ -21,6 +21,22 @@ set_target_properties(adbc_driver_common PROPERTIES
POSITION_INDEPENDENT_CODE ON
target_include_directories(adbc_driver_common PRIVATE
"${REPOSITORY_ROOT}/c/include")
target_link_libraries(adbc_driver_common PUBLIC nanoarrow::nanoarrow)
+# For static builds, we need to install the static library here so downstream
+# applications can link to it
+if(ADBC_BUILD_STATIC)
+ if(ADBC_WITH_VENDORED_NANOARROW)
+ message(WARNING "adbc_driver_common is not installed when
ADBC_WITH_VENDORED_NANOARROW is ON. To use the static libraries, for now you
must provide nanoarrow instead of using the vendored copy"
Review Comment:
Yeah, I tried to install Nanoarrow but CMake failed because of something
about the header not being installable - decided to punt since to start with I
don't think we need to support every possible case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
