Dandandan commented on PR #7422:
URL: https://github.com/apache/arrow-rs/pull/7422#issuecomment-2829456265

   > Do you see the same performance regression for `take stringview`? I'm 
still just digging into the code to see if that is even possible.
   > 
   > Main:
   > 
   > ```
   > take stringview 512     time:   [287.26 ns 287.75 ns 288.28 ns]
   > 
   > take stringview 1024    time:   [489.07 ns 489.99 ns 491.18 ns]
   > ```
   > 
   > PR:
   > 
   > ```
   > take stringview 512     time:   [360.36 ns 361.02 ns 361.95 ns]
   > 
   > take stringview 1024    time:   [633.66 ns 633.79 ns 633.98 ns]
   > ```
   
   I am not at a machine right now to test, but StringView doesn't use this 
code path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to