kapoisu commented on issue #46217: URL: https://github.com/apache/arrow/issues/46217#issuecomment-2834471299
> It's also used by `RemoveExpiredEntriesFromCache`, although as far as I can see that's only used in one test. Yup. I meant ```RemoveExpiredEntriesFromCache``` is just "acquire the mutex and call ```RemoveExpiredEntriesNoMutex```". While ```CheckCacheForExpiredTokens``` calls ```RemoveExpiredEntriesNoMutex```, it also acquires the mutex before that. That means it can call ```RemoveExpiredEntriesFromCache``` directly. Although I'm not sure if moving ```RemoveExpiredEntriesNoMutex```'s logic to ```RemoveExpiredEntriesFromCache``` is a good a idea, considering there may be usages that don't require the mutex in the future? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
