alamb commented on code in PR #7434:
URL: https://github.com/apache/arrow-rs/pull/7434#discussion_r2064188160
##########
arrow-avro/src/codec.rs:
##########
@@ -51,10 +51,21 @@ impl AvroDataType {
Field::new(name, d,
self.nullability.is_some()).with_metadata(self.metadata.clone())
}
+ /// Returns a reference to the codec used by this data type
+ ///
+ /// The codec determines how Avro data is encoded and mapped to Arrow data
types.
+ /// This is useful when you need to inspect or use the specific encoding
of a field.
pub fn codec(&self) -> &Codec {
&self.codec
}
+ /// Returns the nullability status of this data type
Review Comment:
This is really nice -- thank you
##########
arrow-avro/src/codec.rs:
##########
@@ -284,13 +391,55 @@ fn make_data_type<'a>(
ComplexType::Enum(e) => Err(ArrowError::NotYetImplemented(format!(
"Enum of {e:?} not currently supported"
))),
- ComplexType::Map(m) => Err(ArrowError::NotYetImplemented(format!(
- "Map of {m:?} not currently supported"
- ))),
+ ComplexType::Map(m) => {
Review Comment:
this seems to be a new feature (not just string view, but also map support)
Have you had a chance to review this PR?
- https://github.com/apache/arrow-rs/pull/6965 ?
##########
arrow-avro/src/compression.rs:
##########
@@ -23,9 +23,16 @@ use std::io::Read;
pub const CODEC_METADATA_KEY: &str = "avro.codec";
#[derive(Debug, Copy, Clone, Eq, PartialEq)]
+/// Supported compression codecs for Avro data
Review Comment:
Thank you for these comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
