Dandandan opened a new issue, #7450:
URL: https://github.com/apache/arrow-rs/issues/7450

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always 
frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for 
this feature, in addition to  the *what*)
   -->
   
   Currently `RowSelector` contains a `pub skip: bool` which means that the 
rows in the row selector needs to be skipped or not.
   However, this field is not very useful as an optimal representation of a 
`RowSelector` will always be alternating selected and skipped rows.
   
   I think we should consider dropping the `skip` field in order to simplify 
the api (and speed up as well). 
   
   We can represent a `RowSelector` as array of alternating select / skip / 
select rows.
   
   e.g. :
   [0, 10, 5, 10, 5] => select 0, skip 10, select 5, skip 10, select 5
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   
   Drop the `skip` field, update implementation to take care of the new 
representation (select / skip based on alternation rather than via the field, 
(even/odd)).
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features 
you've considered.
   -->
   Other representation, e.g. Vec<Range<..>>
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to