adamreeve commented on PR #44633: URL: https://github.com/apache/arrow/pull/44633#issuecomment-2840729753
I should add that the above changes could all be done as a follow up to this PR so I think we could merge this nearly as-is to get the performance improvement, and then follow up later to fix the comparison inconsistency. Given the breaking change to return -1 instead of throw `InvalidOperationException` has already been released in 19.0.0, I don't think we should break that behaviour again but should stick with returning -1 now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
