kou commented on code in PR #46095: URL: https://github.com/apache/arrow/pull/46095#discussion_r2067916591
########## cpp/src/arrow/filesystem/azurefs.cc: ########## @@ -570,6 +570,16 @@ bool IsContainerNotFound(const Storage::StorageException& e) { return false; } +bool IsForbidden(const Storage::StorageException& e) { + // In some situations, only the ReasonPhrase is set and the + // ErrorCode is empty, so we check both. + if (e.ErrorCode == "AuthorizationFailure" || + e.ReasonPhrase == "This request is not authorized to perform this operation.") { + DCHECK_EQ(e.StatusCode, Http::HttpStatusCode::Forbidden); + } Review Comment: In the case, 404 Not Found may be returned not for cases that container/filesystem doesn't exist too. So we can't use `Http::HttpStatusCode::NotFound` directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org