paleolimbot commented on issue #46270: URL: https://github.com/apache/arrow/issues/46270#issuecomment-2841992436
It's a great point that it's confusing! > How about changing "zero non-NaN values were encountered in that dimension" to "all values in that dimension are NaN"? There also could have been no values in a given dimension (e.g., the example I give in the docstring where Update() was never called). I'll open a PR with a clarification shortly. > Why does dimension_empty() return false if dimension_valid() is false? Wouldn't it be easier for the user if dimension_empty() also returned true in that case? I think this is more user-friendly as is...if you have a query rectangle, you can do `if (dimension_empty(0) && dimension_empty(1)) skipThisRowGroup()` without checking validity. I opened https://github.com/apache/arrow/issues/46267 for just exposing a method that checks for intersection with a rectangle to handle those details for the common case 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
