birschick-bq commented on code in PR #2729:
URL: https://github.com/apache/arrow-adbc/pull/2729#discussion_r2069555527
##########
go/adbc/driver/snowflake/connection.go:
##########
@@ -169,7 +171,16 @@ func isWildcardStr(ident string) bool {
return strings.ContainsAny(ident, "_%")
}
-func (c *connectionImpl) GetObjects(ctx context.Context, depth
adbc.ObjectDepth, catalog, dbSchema, tableName, columnName *string, tableType
[]string) (rdr array.RecordReader, err error) {
+func (c *connectionImpl) GetObjects(ctx context.Context, depth
adbc.ObjectDepth, catalog, dbSchema, tableName, columnName *string, tableType
[]string) (reader array.RecordReader, err error) {
+ var span trace.Span
+ ctx, span = c.StartSpan(ctx, "GetObjects")
+ defer func() {
Review Comment:
This is a suggested "best-practices" way to ensure to check for errors and
set the status before exiting a function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
