westonpace commented on code in PR #7446:
URL: https://github.com/apache/arrow-rs/pull/7446#discussion_r2071855486
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -1911,6 +1914,29 @@ mod tests {
roundtrip(batch, Some(SMALL_SIZE / 2));
}
+ #[test]
+ fn test_fixed_size_binary_in_dict() {
+ let field = Field::new(
+ "a",
+ DataType::Dictionary(
+ Box::new(DataType::UInt8),
+ Box::new(DataType::FixedSizeBinary(4)),
+ ),
Review Comment:
Just to be thorough can we iterate through the various key types to ensure
we got the match statement in byte_array_dictionary correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
