kapoisu commented on code in PR #46283:
URL: https://github.com/apache/arrow/pull/46283#discussion_r2072853947
##########
cpp/src/parquet/encryption/two_level_cache_with_expiration.h:
##########
@@ -110,7 +110,7 @@ class TwoLevelCacheWithExpiration {
return cache_[access_token].cached_item();
}
- void CheckCacheForExpiredTokens(double cache_cleanup_period_seconds) {
+ void CheckCacheForExpiredTokens(double cache_cleanup_period_seconds = 0.0) {
Review Comment:
The parameter indicates that at least cache_cleanup_period_seconds must pass
before checking the expired tokens. However, the gap between each call is
undetermined thus the paramater doesn't implies the actual cleanup period. The
fact that ```CheckCacheForExpiredTokens()``` checks the expired tokens no
matter how much time has passed seems reasonable to me. Or maybe rename the
parameter to something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
