pitrou commented on code in PR #46271:
URL: https://github.com/apache/arrow/pull/46271#discussion_r2072971215
##########
cpp/src/arrow/array/data.h:
##########
@@ -230,7 +234,19 @@ struct ARROW_EXPORT ArrayData {
return null_count.load() != length;
}
- // Access a buffer's data as a typed C pointer
+ /// \brief Access a buffer's data as a typed C pointer
+ ///
+ /// \param i the buffer index
+ /// \param absolute_offset the offset into the buffer
+ ///
+ /// If `absolute_offset` is non-zero, the type `T` must match the
+ /// layout of buffer number `i` for the array's data type; otherwise
+ /// offset computation would be incorrect.
+ ///
+ /// If the given buffer is bit-packed (such as a validity bitmap, or
+ /// the data buffer of a boolean array), then `absolute_offset` must be
+ /// zero for correct results, and any bit offset must be applied manually
+ /// by the caller.
Review Comment:
Well, `GetValues` protects against missing buffers and non-CPU buffers (the
former is important as the validity bitmap is optional).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
