alamb commented on code in PR #7457: URL: https://github.com/apache/arrow-rs/pull/7457#discussion_r2073601989
########## arrow-arith/src/arity.rs: ########## @@ -251,14 +249,16 @@ where /// /// Return an error if the arrays have different lengths or /// the operation is under erroneous -pub fn try_binary<A: ArrayAccessor, B: ArrayAccessor, F, O>( - a: A, - b: B, +pub fn try_binary<A, B, F, O>( Review Comment: Can we go back to the previous definition? I suspect you had a good reason for doing it this way, but I don't understand what it is If we need to retain backward compatibility and want to release this before July, I recommend adding a new method called `try_binary_primitive` and add a link in the documentation for `try_binary` saying it is faster for primitive arrays to use that new function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
