rok commented on code in PR #7459: URL: https://github.com/apache/arrow-rs/pull/7459#discussion_r2074324664
########## parquet/src/file/metadata/reader.rs: ########## @@ -963,15 +962,24 @@ impl ParquetMetaDataReader { let schema_descr = Arc::new(SchemaDescriptor::new(schema)); if let (Some(algo), Some(file_decryption_properties)) = ( - t_file_metadata.encryption_algorithm, + t_file_metadata.encryption_algorithm.clone(), file_decryption_properties, ) { // File has a plaintext footer but encryption algorithm is set file_decryptor = Some(get_file_decryptor( algo, - t_file_metadata.footer_signing_key_metadata.as_deref(), + t_file_metadata + .footer_signing_key_metadata + .clone() + .as_deref(), file_decryption_properties, )?); + if file_decryption_properties.check_plaintext_footer_integrity() { + file_decryptor + .clone() + .unwrap() Review Comment: Nice. Changed as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org