lidavidm commented on code in PR #2729:
URL: https://github.com/apache/arrow-adbc/pull/2729#discussion_r2074342082
##########
go/adbc/driver/flightsql/flightsql_driver.go:
##########
@@ -100,7 +101,7 @@ type driverImpl struct {
// passed through the options map.
type Driver interface {
adbc.Driver
- NewDatabaseWithOptions(map[string]string, ...grpc.DialOption)
(adbc.Database, error)
+ NewDatabaseWithOptions(context.Context, map[string]string,
...grpc.DialOption) (adbc.Database, error)
Review Comment:
Down the line we should try to fix this uniformly...
https://github.com/apache/arrow-adbc/issues/2772 :grimacing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
