kou commented on code in PR #46261: URL: https://github.com/apache/arrow/pull/46261#discussion_r2074772861
########## c_glib/arrow-glib/compute.cpp: ########## @@ -37,6 +37,8 @@ #include <arrow/acero/exec_plan.h> #include <arrow/acero/options.h> +auto registration_status_ = arrow::compute::RegisterComputeKernels(); Review Comment: > On places like pyarrow we lose the namespace Why? It seems that PyArrow doesn't use `using arrow::compute`. > If yes, which one do you prefer? I prefer `::arrow::compute::Initialize()` (or `arrow::compute::InitializeCompute`). `Arrow` (and `Compute`) in `arrow::compute::InitializeArrowCompute()` are redundant. If we want to initialize not only kernels but also others, `InitializeComputeKernels()` will be misleading (or users need to call `InitializeComputeKernels()` and `InitializeSomething()`.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
