kou commented on code in PR #46339:
URL: https://github.com/apache/arrow/pull/46339#discussion_r2076605309
##########
ci/scripts/cpp_build.sh:
##########
@@ -283,7 +283,10 @@ else
fi
if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
- time meson install
+ time {
+ meson compile -j $[${n_jobs} + 1];
+ meson install;
+ }
else
export CMAKE_BUILD_PARALLEL_LEVEL=${CMAKE_BUILD_PARALLEL_LEVEL:-$[${n_jobs}
+ 1]}
Review Comment:
How about defining `ARROW_BUILD_PARALLEL` or something and use it as the
default for Meson and CMake?
```shell
: ${ARROW_BUILD_PARALLEL:=$[${n_jobs} + 1]}
if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
meson compile -j ${ARROW_BUILD_PARALLEL}
else
export CMAKE_BUILD_PARALLEL_LEVEL=${ARROW_BUILD_PARALLEL}
fi
```
##########
ci/scripts/cpp_build.sh:
##########
@@ -283,7 +283,10 @@ else
fi
if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
- time meson install
+ time {
+ meson compile -j $[${n_jobs} + 1];
+ meson install;
+ }
Review Comment:
We need only compile time because install time will not be slow:
```suggestion
time meson compile -j $[${n_jobs} + 1]
meson install
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
