kou commented on code in PR #46117: URL: https://github.com/apache/arrow/pull/46117#discussion_r2076609206
########## cpp/src/arrow/ipc/meson.build: ########## @@ -0,0 +1,127 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +exc = executable( + 'arrow-feather-test', + sources: ['feather_test.cc'], + dependencies: [arrow_ipc_deps, arrow_test_dep], +) +test('arrow-feather-test', exc) + +ipc_tests = [ + 'json_simple_test', + 'message_internal_test', + 'read_write_test', + 'tensor_test', +] + +foreach ipc_test : ipc_tests + test_name = 'arrow-ipc-@0@'.format(ipc_test.replace('_', '-')) + exc = executable( + test_name, + sources: ['@0@.cc'.format(ipc_test)], + dependencies: [arrow_ipc_deps, arrow_test_dep], + ) + test(test_name, exc) +endforeach + +install_headers( + [ + 'api.h', + 'dictionary.h', + 'feather.h', + 'json_simple.h', + 'message.h', + 'options.h', + 'reader.h', + 'test_common.h', + 'type_fwd.h', + 'util.h', + 'writer.h', + ], + subdir: 'arrow/ipc', +) + +if needs_utilities or needs_integration + file_to_stream_exc = executable( + 'arrow-file-to-stream', + sources: ['file_to_stream.cc'], + dependencies: [arrow_dep], + install: needs_utilities, + ) + + stream_to_file_exc = executable( + 'arrow-stream-to-file', + sources: ['stream_to_file.cc'], + dependencies: [arrow_dep], + install: needs_utilities, + ) + + if needs_integration + # TODO: The CMake configuration would add these executables + # to an arrow-integration target, which is in turn + # used by arrow-all. The targets are modified, but not + # used within Arrow C++ (?) - do we need to replicate that here? + endif +endif + +exc = executable( + 'arrow-ipc-read-write-benchmark', + sources: ['read_write_benchmark.cc'], + dependencies: [arrow_benchmark_dep], +) +benchmark('arrow-ipc-read-write-benchmark', exc) + +if needs_fuzzing or (needs_utilities +and needs_testing +and needs_lz4 +and needs_zstd +) + fuzz_corpus_exc = executable( + 'arrow-ipc-generate-fuzz-corpus', + sources: ['generate_fuzz_corpus.cc'], + dependencies: [arrow_test_dep], + ) + + tensor_fuzz_corpus_exc = executable( + 'arrow-ipc-generate-tensor-fuzz-corpus', + sources: ['generate_tensor_fuzz_corpus.cc'], + dependencies: [arrow_test_dep], + ) +endif + +ipc_fuzz_targets = ['file_fuzz', 'stream_fuzz', 'tensor_stream_fuzz'] + +if needs_fuzzing + if meson.version() < '1.8.0' + error( + ' Meson >= 1.8.0 is required for fuzzing support, found @0@'.format( + meson.version(), + ), + ) + endif Review Comment: We need Meson 1.8.0 or later for `-Db_sanitize=fuzzer`, right? ########## cpp/src/arrow/ipc/meson.build: ########## @@ -0,0 +1,127 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +exc = executable( + 'arrow-feather-test', + sources: ['feather_test.cc'], + dependencies: [arrow_ipc_deps, arrow_test_dep], +) +test('arrow-feather-test', exc) + +ipc_tests = [ + 'json_simple_test', + 'message_internal_test', + 'read_write_test', + 'tensor_test', +] + +foreach ipc_test : ipc_tests + test_name = 'arrow-ipc-@0@'.format(ipc_test.replace('_', '-')) + exc = executable( + test_name, + sources: ['@0@.cc'.format(ipc_test)], + dependencies: [arrow_ipc_deps, arrow_test_dep], + ) + test(test_name, exc) +endforeach + +install_headers( + [ + 'api.h', + 'dictionary.h', + 'feather.h', + 'json_simple.h', + 'message.h', + 'options.h', + 'reader.h', + 'test_common.h', + 'type_fwd.h', + 'util.h', + 'writer.h', + ], + subdir: 'arrow/ipc', +) + +if needs_utilities or needs_integration + file_to_stream_exc = executable( + 'arrow-file-to-stream', + sources: ['file_to_stream.cc'], + dependencies: [arrow_dep], + install: needs_utilities, + ) + + stream_to_file_exc = executable( + 'arrow-stream-to-file', + sources: ['stream_to_file.cc'], + dependencies: [arrow_dep], + install: needs_utilities, + ) + + if needs_integration + # TODO: The CMake configuration would add these executables + # to an arrow-integration target, which is in turn + # used by arrow-all. The targets are modified, but not + # used within Arrow C++ (?) - do we need to replicate that here? + endif Review Comment: We don't need to replicate with Meson. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
