MartinNowak commented on code in PR #39216:
URL: https://github.com/apache/arrow/pull/39216#discussion_r2077583207
##########
cpp/src/arrow/dataset/file_parquet_encryption_test.cc:
##########
@@ -142,12 +145,107 @@ class DatasetEncryptionTest : public ::testing::Test {
kms_connection_config_;
};
-// This test demonstrates the process of writing a partitioned Parquet file
with the same
-// encryption properties applied to each file within the dataset. The
encryption
-// properties are determined based on the selected columns. After writing the
dataset, the
-// test reads the data back and verifies that it can be successfully decrypted
and
-// scanned.
-TEST_F(DatasetEncryptionTest, WriteReadDatasetWithEncryption) {
+class DatasetEncryptionTestUniformEncryption : public ::testing::Test {
Review Comment:
While it makes sense to add missing unittests for the C++ implementation,
this seems out of scope for completing the python api.
##########
python/pyarrow/_parquet_encryption.pyx:
##########
@@ -51,7 +51,7 @@ cdef class EncryptionConfiguration(_Weakrefable):
# Avoid mistakingly creating attributes
__slots__ = ()
- def __init__(self, footer_key, *, column_keys=None,
+ def __init__(self, footer_key, *, column_keys=None,
uniform_encryption=None,
Review Comment:
Defaults live in the C++ implementation, compare with e.g. plaintext_footer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
