adamreeve commented on PR #7477: URL: https://github.com/apache/arrow-rs/pull/7477#issuecomment-2860504756
> Looks to me like there is a conflict that needs to be resolved, but after that it should be good to go This is resolved now, I had to account for the new `footer_signature_verification` option that was added. > It would be nice to test this even with a mock key retriever. There are already some tests that cover this, eg: https://github.com/apache/arrow-rs/blob/fb72b8f7cb805f7abfaf325d19b3fb92aeb247ab/parquet/tests/encryption/encryption.rs#L252 Given this PR is only a refactor I don't think there are any extra tests needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
