zhuqi-lucas commented on code in PR #7470:
URL: https://github.com/apache/arrow-rs/pull/7470#discussion_r2080825553


##########
.gitignore:
##########
@@ -97,3 +97,6 @@ $RECYCLE.BIN/
 # Python virtual env in parquet crate
 parquet/pytest/venv/
 __pycache__/
+
+# Parquet file from arrow_reader_clickbench
+hits_0.parquet

Review Comment:
   Great work, thank you @alamb , one suggestion is we can change 
hits_0.parquet to hits_1.parquet, because i found that hits_0.parquet did not 
cover the case which one page cache will cause cache missing, but the 
hits_1.parquet can mock this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to