lidavidm commented on code in PR #2729: URL: https://github.com/apache/arrow-adbc/pull/2729#discussion_r2081735642
########## go/adbc/driver/internal/driverbase/rotating_file_writer.go: ########## Review Comment: In any case, I'd ask (1) let's not dump stuff directly into $HOME; can we use something more proper/follow desktop standards? (2) `adbcfile` is a bit of an odd name to me, but I guess we're stuck trying not to accidentally alias some (future) standard OTel sink somehow (3) Ideally we could use the existing log config as the sink? Or unify them? We currently have an API to set an slog sink; it would be best if there was at least some plan to migrate/settle on a single log provider, since OTel has its own logging API. (Thankfully, the current logging API is also in `ext.go` so I'm more comfortable updating it.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
