ianmcook commented on a change in pull request #9800:
URL: https://github.com/apache/arrow/pull/9800#discussion_r607390639
##########
File path: r/R/filesystem.R
##########
@@ -273,33 +273,53 @@ FileSystem$from_uri <- function(uri) {
fs___FileSystemFromUri(uri)
}
-get_path_and_filesystem <- function(x, filesystem = NULL) {
+get_paths_and_filesystem <- function(x, filesystem = NULL) {
Review comment:
~~I attempted that first, but that caused multiple errors, prompting me
to do it this way~~ Oops that's incorrect; it was actually because we want need
only one `fs` in the output in the case where there are multiple files, and
using `lapply` would have required extra code to handle that. This was cleaner.
Also, it only took a few small changes to change this function to handle vector
`x`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
