EnricoMi commented on code in PR #46180:
URL: https://github.com/apache/arrow/pull/46180#discussion_r2082307442
##########
cpp/src/arrow/testing/gtest_util.cc:
##########
@@ -1020,19 +1018,19 @@ std::shared_ptr<Array> MakeComplex128(const
std::shared_ptr<Array>& real,
}
std::shared_ptr<Array> ExampleUuid() {
- auto arr = ArrayFromJSON(
+ auto arr = arrow::ArrayFromJSON(
Review Comment:
My thinking was this file provides `*ArrayFromJSON` alias for existing test
code, so the inner implementation should be based on the public
`*ArrayFromJSONString` methods. A number of methods above follow that rule.
Makes sense to have those methods that do not return a `Result` to not
duplicate the `Result`-unwrapping.
What is your methodology here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
