kou commented on code in PR #46303:
URL: https://github.com/apache/arrow/pull/46303#discussion_r2082517906
##########
cpp/src/arrow/compute/kernels/vector_rank.cc:
##########
@@ -381,9 +381,13 @@ class RankMetaFunction : public
RankMetaFunctionBase<RankMetaFunction> {
}
RankMetaFunction()
- : RankMetaFunctionBase("rank", Arity::Unary(), rank_doc,
&kDefaultOptions) {}
+ : RankMetaFunctionBase("rank", Arity::Unary(), rank_doc,
GetDefaultOptions()) {}
Review Comment:
OK. Let's choose `GetDefaultOptions()` here. `GetDefaultOptions()` is more
straightforward than
https://github.com/apache/arrow/pull/46303#discussion_r2073899428 because
developers don't need to know IIFE and static variable lifetime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
