jkylling commented on code in PR #7307:
URL: https://github.com/apache/arrow-rs/pull/7307#discussion_r2083595646
##########
parquet/src/arrow/array_reader/builder.rs:
##########
@@ -52,12 +70,13 @@ fn build_reader(
field: &ParquetField,
mask: &ProjectionMask,
row_groups: &dyn RowGroups,
+ row_number_column: Option<&str>,
Review Comment:
This would simplify usage of the feature. Having to keep track of the
additional row number column is quite cumbersome in clients of this API. One
option could be to extend
[ParquetFieldType](https://github.com/apache/arrow-rs/blob/fc6936aff50b0b1c8bea984bba2d57dac68a98b3/parquet/src/arrow/schema/complex.rs#L84)
with an additional row number type and add it based on the extension type in
[ArrowReaderMetadata::with_supplied_metadata](https://github.com/apache/arrow-rs/blob/5350728bb61a3a0a93a8fe797c969a1e6d264169/parquet/src/arrow/arrow_reader/mod.rs#L452)?
@etseidl @alamb what do you think about this approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
