pitrou commented on code in PR #46346:
URL: https://github.com/apache/arrow/pull/46346#discussion_r2083972922
##########
cpp/src/arrow/io/caching.cc:
##########
@@ -188,7 +188,9 @@ struct ReadRangeCache::Impl {
entries = std::move(new_entries);
}
// Prefetch immediately, regardless of executor availability, if possible
- return file->WillNeed(ranges);
+ // As this is optimisation only, failures should not be treated as fatal
+ ARROW_UNUSED(file->WillNeed(ranges));
Review Comment:
I would rather we just ignore IOError but less other errors propagate (they
might be indicative of a logic error).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
