OmriSteiner commented on PR #351: URL: https://github.com/apache/arrow-rs-object-store/pull/351#issuecomment-2871234343
> Failure on the main is related with this? That same test passed on this branch. The only reason I can think of is that statistically the delete request in the test fails - and this change causes it to both (!): * Not retry * Not fail the request I can get behind not retry - maybe there was an error which was previously mapped to `Timeout` / `Connect` / `Decode` and now it is mapped to `Interrupted` - which is retried in case the request is not idempotent (delete isn't). But I would expect the test to panic at `src/integration.rs:955` because the request fails. ----------------------- To be fair, it's possible that TCP-RST on connect actually caused this to convert `Connect` errors to `Interrupted` errors. WDYT about only doing the error refinement in case `kind == Unknown`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
