CurtHagenlocher commented on code in PR #2822: URL: https://github.com/apache/arrow-adbc/pull/2822#discussion_r2087012399
########## csharp/src/Drivers/Apache/Thrift/Sasl/TSaslTransport.cs: ########## @@ -0,0 +1,181 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +using System; +using System.Security.Authentication; +using System.Text; +using System.Threading.Tasks; +using System.Threading; +using Thrift; +using Thrift.Transport; + +namespace Apache.Arrow.Adbc.Drivers.Apache.Thrift.Sasl +{ + public class TSaslTransport : TEndpointTransport + { + private readonly TTransport _innerTransport; + private readonly ISaslMechanism _saslMechanism; + + protected const int MECHANISM_NAME_BYTES = 1; + protected const int STATUS_BYTES = 1; + protected const int PAYLOAD_LENGTH_BYTES = 4; + + private byte[] messageHeader = new byte[STATUS_BYTES + PAYLOAD_LENGTH_BYTES]; Review Comment: Consider using `stackalloc` and a local var instead of a heap-allocated array -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
