alamb commented on code in PR #7502:
URL: https://github.com/apache/arrow-rs/pull/7502#discussion_r2093302101
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -679,38 +680,32 @@ impl<T: ChunkReader + 'static>
ParquetRecordBatchReaderBuilder<T> {
};
let mut filter = self.filter;
- let mut selection = self.selection;
+ let mut plan_builder =
ReadPlanBuilder::new(batch_size).with_selection(self.selection);
Review Comment:
The high level idea is to avoid manipulating the `RowSelection` directly in
the APIs and instead manipulate them via `ReadPlanBuilder` / `ReadPlan`
The reason to encapsulate them in a new struct is to make it feasible to add
additional complexity such as cached filter results and better filter row
representations
This PR simply moves code around -- it does not intended to change any of
the actual logic yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
