alamb commented on code in PR #7521: URL: https://github.com/apache/arrow-rs/pull/7521#discussion_r2093343560
########## parquet/src/arrow/array_reader/mod.rs: ########## @@ -45,7 +45,7 @@ mod struct_array; #[cfg(test)] mod test_util; -pub use builder::build_array_reader; +pub(crate) use builder::ArrayReaderBuilder; Review Comment: I personally find the use of `pub use` in non pub modules confusing to reason about what is pub and what is not. I think using `pub(crate)` to make it explicit this is crate private makes it easier to understand -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
