Re: [PR] Fix 1.87 Clippy Lints [arrow-rs-object-store]

Fri, 16 May 2025 12:12:09 -0700 


alamb commented on code in PR #370:
URL: 
https://github.com/apache/arrow-rs-object-store/pull/370#discussion_r2093548639


##########
src/client/retry.rs:
##########
@@ -33,7 +33,11 @@ use web_time::{Duration, Instant};
 
 /// Retry request error
 #[derive(Debug, thiserror::Error)]
-pub struct RetryError {
+pub struct RetryError(Box<RetryErrorImpl>);

Review Comment:
   I double checked and indeed I agree this error is not public
   ```shell
   cargo doc --all-features --open
   ```
   
   ![Screenshot 2025-05-16 at 2 16 11 
PM](https://github.com/user-attachments/assets/a73134e4-9b1d-42f2-8e51-0fc158a51ef5)
   



##########
src/client/retry.rs:
##########
@@ -33,7 +33,11 @@ use web_time::{Duration, Instant};
 
 /// Retry request error
 #[derive(Debug, thiserror::Error)]
-pub struct RetryError {
+pub struct RetryError(Box<RetryErrorImpl>);

Review Comment:
   I double checked and indeed I agree this error is not public
   ```shell
   cargo doc --all-features --open
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to