Dandandan opened a new pull request, #7536:
URL: https://github.com/apache/arrow-rs/pull/7536
This commit refactors the `RowSelector` and `RowSelection` structs to
simplify the API and reduce memory overhead.
The `skip` field has been removed from `RowSelector`. The selection or
skipping of rows is now determined by an alternating pattern within the
`RowSelection` struct.
The `RowSelection` struct has been updated to include a `starts_with_select`
field, which indicates whether the first selector in the `selectors` vector
represents a select or a skip operation. The `selectors` vector now stores
`RowSelector` instances that represent alternating counts of rows.
All methods within `RowSelection` and the `ParquetRecordBatchReader` have
been updated to work with this new structure. I have also updated the tests to
reflect these changes.
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
This is just an experiment to use jules.google.com to implement some issues.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
