lidavidm commented on code in PR #764:
URL: https://github.com/apache/arrow-java/pull/764#discussion_r2103660559
##########
ci/scripts/jni_build.sh:
##########
@@ -50,11 +50,15 @@ Darwin)
esac
: "${ARROW_JAVA_BUILD_TESTS:=${ARROW_BUILD_TESTS:-ON}}"
+: "${ARROW_VCPKG:=OFF}"
: "${CMAKE_BUILD_TYPE:=release}"
read -ra EXTRA_CMAKE_OPTIONS <<<"${JAVA_JNI_CMAKE_ARGS:-}"
+# Must set ARROW_VCPKG because upstream Findutf8proc.cmake checks that to
+# determine what to do
cmake \
-S "${source_dir}" \
-B "${build_dir}" \
+ -DARROW_VCPKG="${ARROW_VCPKG}" \
Review Comment:
I tried this and it doesn't seem to work: I don't think the Java JNI CMake
code has anything to detect this. Also, `Findutf8proc.cmake` installed by
Arrow's CMake checks `ARROW_VCPKG`, but I don't see any other code installed to
set this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
