kou commented on code in PR #46099: URL: https://github.com/apache/arrow/pull/46099#discussion_r2106130835
########## dev/release/rat_exclude_files.txt: ########## @@ -13,6 +13,8 @@ ci/vcpkg/*.patch CHANGELOG.md cpp/CHANGELOG_PARQUET.md cpp/src/arrow/c/dlpack_abi.h +cpp/src/arrow/flight/sql/odbc/odbc.def +cpp/src/arrow/flight/sql/odbc/install/install_amd64.cmd Review Comment: Could you add license header to all files expect that don't support comment. We can use `rem ...` in `.cmd` and `; ...` in `.dev` for comments. ########## dev/release/rat_exclude_files.txt: ########## @@ -13,6 +13,8 @@ ci/vcpkg/*.patch CHANGELOG.md cpp/CHANGELOG_PARQUET.md cpp/src/arrow/c/dlpack_abi.h +cpp/src/arrow/flight/sql/odbc/odbc.def +cpp/src/arrow/flight/sql/odbc/install/install_amd64.cmd Review Comment: Could you add license header to all files expect that don't support comment? We can use `rem ...` in `.cmd` and `; ...` in `.dev` for comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
