westonpace commented on a change in pull request #9892:
URL: https://github.com/apache/arrow/pull/9892#discussion_r608213491
##########
File path: cpp/src/arrow/dataset/scanner.h
##########
@@ -32,6 +32,7 @@
#include "arrow/memory_pool.h"
#include "arrow/type_fwd.h"
#include "arrow/util/async_generator.h"
+#include "arrow/util/thread_pool.h"
Review comment:
Sorry, I was not clear with my language. By "no types beyond
`std::function`" I meant "no classes or structs". We would still need to
include `async_generator.h` for the functions (e.g. `MakeMappedGenerator`).
So without the typedef you still have the problem that you cannot forward
declare the `MakeXyz` functions without including `<functional>` in the forward
declaration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
