pitrou commented on code in PR #45818:
URL: https://github.com/apache/arrow/pull/45818#discussion_r2106943105
##########
python/pyarrow/tests/test_scalars.py:
##########
@@ -219,6 +220,9 @@ def test_bool():
assert true.as_py() is True
assert false.as_py() is False
+ assert bool(true) is True
+ assert bool(false) is False
Review Comment:
Perhaps also test the case where the boolean isn't valid?
Something like:
```suggestion
assert bool(false) is False
null = pa.scalar(None, type=pa.bool_())
assert isinstance(null, pa.BooleanScalar)
# other tests to be added
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
