ianmcook commented on a change in pull request #9915:
URL: https://github.com/apache/arrow/pull/9915#discussion_r608236555
##########
File path: r/R/dplyr.R
##########
@@ -520,6 +536,60 @@ arrow_stringr_string_replace_function <- function(FUN,
max_replacements) {
}
}
+# this function assigns definitions for the stringr pattern modifier functions
+# (fixed, regex, etc.) plus a required helper function (ensure_opts) in the
+# calling function's environment, where they are required to evaluate `pattern`
Review comment:
D'oh, that seem so obvious now 🤦♂️ Thanks
##########
File path: r/R/dplyr.R
##########
@@ -520,6 +536,60 @@ arrow_stringr_string_replace_function <- function(FUN,
max_replacements) {
}
}
+# this function assigns definitions for the stringr pattern modifier functions
+# (fixed, regex, etc.) plus a required helper function (ensure_opts) in the
+# calling function's environment, where they are required to evaluate `pattern`
Review comment:
D'oh, that seems so obvious now 🤦♂️ Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
