rtadepalli commented on code in PR #772:
URL: https://github.com/apache/arrow-java/pull/772#discussion_r2107891080
##########
flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/test/TestFlightSql.java:
##########
@@ -915,28 +914,28 @@ public void testGetCommandExportedKeys() throws Exception
{
final List<List<String>> results = getResults(stream);
- final List<Matcher<String>> matchers =
+ final List<Condition<String>> matchers =
asList(
- nullValue(String.class), // pk_catalog_name
- is("APP"), // pk_schema_name
- is("FOREIGNTABLE"), // pk_table_name
- is("ID"), // pk_column_name
- nullValue(String.class), // fk_catalog_name
- is("APP"), // fk_schema_name
- is("INTTABLE"), // fk_table_name
- is("FOREIGNID"), // fk_column_name
- is("1"), // key_sequence
- containsString("SQL"), // fk_key_name
- containsString("SQL"), // pk_key_name
- is("3"), // update_rule
- is("3")); // delete_rule
+ new HamcrestCondition<>(nullValue(String.class)), //
pk_catalog_name
Review Comment:
Not particularly certain how to get rid of Hamcrest entirely here. I was
aware of `HamcrestCondition` so using that, but open to suggestions if anyone
knows how this list-based matching can be accomplished solely using assertj.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
