zeroshade commented on code in PR #46372:
URL: https://github.com/apache/arrow/pull/46372#discussion_r2109621841
##########
cpp/src/parquet/variant.cc:
##########
@@ -300,8 +300,7 @@ VariantType VariantValue::getType() const {
VariantBasicType basic_type = getBasicType();
switch (basic_type) {
case VariantBasicType::Primitive: {
- auto primitive_type =
- static_cast<VariantPrimitiveType>(value_[0] >> kValueHeaderBitShift);
+ auto primitive_type = static_cast<VariantPrimitiveType>(valueHeader());
Review Comment:
I'm a bit confused. `valueHeader` seems to be just doing `>>
kValueHeaderBitShift`, which means that the primitive type would be
`valueHeader() & 0x3f`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
