eric-wang-1990 opened a new pull request, #2884: URL: https://github.com/apache/arrow-adbc/pull/2884
# Arrow-ADBC Catalog Parameter Support ## Overview This branch adds support for properly handling catalog parameters in the C# ADBC driver for Databricks, with special handling for the legacy "SPARK" catalog. The implementation ensures backward compatibility with tools that expect "SPARK" to act as a default catalog alias while also supporting multiple catalog configurations. ## Key Changes 1. **Legacy SPARK Catalog Handling**: Added special handling for the "SPARK" catalog name, treating it as a null catalog to trigger default catalog behavior in the underlying API. 2. **Multiple Catalog Support**: Enhanced the implementation to respect the `EnableMultipleCatalogSupport` configuration setting, with proper behavior for both enabled and disabled states. 3. **Metadata Query Optimization**: Implemented optimized metadata query handling (GetCatalogs, GetSchemas, GetTables, GetColumns) that avoids unnecessary RPC calls when possible. 4. **Protected Method Visibility**: Modified method visibility in base classes to allow proper overriding in derived classes, enabling specialized catalog handling. 5. **Comprehensive Testing**: Added tests to verify the behavior of metadata queries with different catalog settings and configurations. ## Implementation Details The implementation follows a clean approach that: - Properly handles the "SPARK" catalog as a special case - Returns synthetic results for certain metadata queries to avoid unnecessary network calls - Maintains schema compatibility between real and synthetic results - Provides proper encapsulation of the multiple catalog support flag These changes improve compatibility with various client tools while maintaining performance and adhering to the ADBC specification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
