mapleFU commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r2110820266
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1741,15 +1752,22 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
if (num_values != num_spaced_values) {
current_value_encoder_->PutSpaced(values,
static_cast<int>(num_spaced_values),
valid_bits, valid_bits_offset);
+ UpdateBloomFilterSpaced(values, num_spaced_values, valid_bits,
valid_bits_offset);
} else {
current_value_encoder_->Put(values, static_cast<int>(num_values));
+ UpdateBloomFilter(values, num_values);
}
if (page_statistics_ != nullptr) {
page_statistics_->UpdateSpaced(values, valid_bits, valid_bits_offset,
num_spaced_values, num_values, num_nulls);
}
UpdateUnencodedDataBytes();
}
+
+ void UpdateBloomFilter(const T* values, int64_t num_values);
Review Comment:
Seems update stats is not in statistics like
`TypedStatistics::Update/UpdateSpaced`? Both ok to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
