Alex-PLACET commented on code in PR #46530:
URL: https://github.com/apache/arrow/pull/46530#discussion_r2111241125
##########
dev/archery/archery/cli.py:
##########
@@ -844,29 +868,28 @@ def integration(with_all=False, random_seed=12345,
**args):
implementations = ['cpp', 'csharp', 'java', 'js', 'go', 'nanoarrow',
'rust']
formats = ['ipc', 'flight', 'c_data']
- enabled_implementations = 0
+ enabled_implementations : bool = False
for lang in implementations:
param = f'with_{lang}'
if with_all:
args[param] = with_all
- enabled_implementations += args[param]
+ enabled_implementations = True
Review Comment:
I finally simplified the code to raise an error if no implementation is
selected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
