kou commented on code in PR #46615:
URL: https://github.com/apache/arrow/pull/46615#discussion_r2111265098
##########
c_glib/arrow-glib/composite-data-type.h:
##########
@@ -26,10 +26,25 @@
G_BEGIN_DECLS
+#define GARROW_TYPE_BASE_LIST_DATA_TYPE (garrow_base_list_data_type_get_type())
+GARROW_AVAILABLE_IN_21_0
+G_DECLARE_DERIVABLE_TYPE(GArrowBaseListDataType,
+ garrow_base_list_data_type,
+ GARROW,
+ BASE_LIST_DATA_TYPE,
+ GArrowDataType)
+struct _GArrowBaseListDataTypeClass
+{
+ GArrowDataTypeClass parent_class;
+};
+
#define GARROW_TYPE_LIST_DATA_TYPE (garrow_list_data_type_get_type())
GARROW_AVAILABLE_IN_ALL
-G_DECLARE_DERIVABLE_TYPE(
- GArrowListDataType, garrow_list_data_type, GARROW, LIST_DATA_TYPE,
GArrowDataType)
+G_DECLARE_DERIVABLE_TYPE(GArrowListDataType,
+ garrow_list_data_type,
+ GARROW,
+ LIST_DATA_TYPE,
+ GArrowBaseListDataType)
struct _GArrowListDataTypeClass
{
GArrowDataTypeClass parent_class;
Review Comment:
```suggestion
GArrowBaseListDataTypeClass parent_class;
```
##########
c_glib/arrow-glib/composite-data-type.cpp:
##########
@@ -51,6 +53,17 @@ G_BEGIN_DECLS
* #GArrowRunEndEncodedDataType is a class for run end encoded data type.
*/
+G_DEFINE_TYPE(GArrowBaseListDataType, garrow_base_list_data_type,
GARROW_TYPE_DATA_TYPE)
+
+static void
+garrow_base_list_data_type_init(GArrowBaseListDataType *object)
+{
+}
+
+static void
+garrow_base_list_data_type_class_init(GArrowBaseListDataTypeClass *klass)
+{
+}
G_DEFINE_TYPE(GArrowListDataType, garrow_list_data_type, GARROW_TYPE_DATA_TYPE)
Review Comment:
```suggestion
G_DEFINE_TYPE(GArrowListDataType, garrow_list_data_type,
GARROW_TYPE_BASE_LIST_DATA_TYPE)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
