andishgar commented on PR #46625: URL: https://github.com/apache/arrow/pull/46625#issuecomment-2916622430
@kou I have several questions related to our discussion: 1-The following code demonstrates a practical case where some buffers are copied while others are only viewed. In such a scenario, should arrow::ArrayStatistics be shared or Copied? https://github.com/apache/arrow/blob/b3e4d2244e1b2449efed54dec6e7c79405a029db/cpp/src/arrow/gpu/cuda_test.cc#L1231-L1234 2-My solution might be incorrect on GPUs that do not support Unified Addressing, as noted in the code below. https://github.com/apache/arrow/blob/b3e4d2244e1b2449efed54dec6e7c79405a029db/cpp/src/arrow/gpu/cuda_test.cc#L1196-L1202 Would it be possible to modify `arrow::Buffer::ViewOrCopy` to indicate whether the buffer was actually copied or not? Since it's clear within the method whether a copy occurs https://github.com/apache/arrow/blob/b3e4d2244e1b2449efed54dec6e7c79405a029db/cpp/src/arrow/buffer.cc#L143-L150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
