kou commented on PR #46622:
URL: https://github.com/apache/arrow/pull/46622#issuecomment-2917915721
Could you add this to prevent build error on macOS?
```diff
diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index 4bf162d7b1..5b3bbcb6bc 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -192,6 +192,8 @@ jobs:
ARROW_BUILD_TESTS: ON
ARROW_DATASET: ON
ARROW_FLIGHT: ON
+ ARROW_FLIGHT_SQL: ON
+ ARROW_FLIGHT_SQL_ODBC: ON
ARROW_GANDIVA: ON
ARROW_GCS: ON
ARROW_HDFS: ON
```
Or should we disable the ODBC driver on non Windows?
```diff
diff --git a/cpp/cmake_modules/DefineOptions.cmake
b/cpp/cmake_modules/DefineOptions.cmake
index bf3e5e7c27..18e40649f7 100644
--- a/cpp/cmake_modules/DefineOptions.cmake
+++ b/cpp/cmake_modules/DefineOptions.cmake
@@ -107,6 +107,10 @@ macro(tsort_bool_option_dependencies)
endmacro()
macro(resolve_option_dependencies)
+ # Arrow Flight SQL ODBC is available only for Windows for now.
+ if(NOT MSVC_TOOLCHAIN)
+ set(ARROW_FLIGHT_SQL_ODBC OFF)
+ endif()
if(MSVC_TOOLCHAIN)
set(ARROW_USE_GLOG OFF)
endif()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
