nalimilan opened a new pull request, #556: URL: https://github.com/apache/arrow-julia/pull/556
Invalid indices were used with `OffsetArray`s as 1-based indexing was assumed. Fix this, and always wrap them in a `ToArrow` objet so that they are consistently turned into 1-based arrays. This allows dropping special code for `CategoricalArray` in favor of using the standard `DataAPI.refpool` API combined with the Arrow extension point added to CategoricalArrays (https://github.com/JuliaData/CategoricalArrays.jl/pull/415). If this looks good I'll backport https://github.com/JuliaData/CategoricalArrays.jl/pull/415 to a minor CategoricalArrays release, as currently it's only on master (soon to become 1.0). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
