lidavidm commented on code in PR #45859:
URL: https://github.com/apache/arrow/pull/45859#discussion_r2115239145
##########
cpp/src/arrow/util/tracing_internal.cc:
##########
@@ -97,6 +97,10 @@ class OtlpOStreamExporter final : public
sdktrace::SpanExporter {
std::chrono::microseconds(0)) noexcept override {
return exporter_.Shutdown(timeout);
}
+ // XXX: OTel 1.19 silent breaking change: this must be overridden
+ bool ForceFlush(std::chrono::microseconds /*timeout*/) noexcept override {
+ return true;
Review Comment:
SGTM, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
