IIFE commented on PR #2858: URL: https://github.com/apache/arrow-adbc/pull/2858#issuecomment-2922206815
> Also I see `gendef` being invoked, but it's not installed by CMake - that probably also needs to be tweaked Yeah that's needed to generate the DEF file, which is then used to create the lib import > It looks like tests might not fully build: > > ``` > C:/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: validation/Debug/libadbc_validation_util.a(adbc_validation_util.cc.obj): in function `adbc_validation::StatementGetOption[abi:cxx11](AdbcStatement*, std::basic_string_view<char, std::char_traits<char> >, AdbcError*)': > D:/a/arrow-adbc/arrow-adbc/c/validation/adbc_validation_util.cc:50: undefined reference to `__imp_AdbcStatementGetOption' > ``` > > I'm OK disabling tests for time time being if we can just get DLLs to build properly (we could perhaps just verify that DLLs and implibs exist) Hmm interesting, I didn't encounter this. Suggests the DEF/Lib is not getting generated? > Oh wait - is the `dll.a` sufficient? (That's being installed.) Does the `.def` file need to be installed? Unfortunately the DLL by itself is not sufficient, as on Windows the LIB import file is needed in order to link at build time. So without the LIB file the test projects don't build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
