toddmeng-db commented on code in PR #2896:
URL: https://github.com/apache/arrow-adbc/pull/2896#discussion_r2116831766
##########
csharp/src/Drivers/Databricks/DatabricksStatement.cs:
##########
@@ -41,6 +41,19 @@ internal class DatabricksStatement : SparkStatement,
IHiveServer2Statement
public DatabricksStatement(DatabricksConnection connection)
: base(connection)
{
+ // set the catalog name for legacy compatibility
+ // TODO: use catalog and schema fields in hiveserver2 connection
instad of DefaultNamespace so we don't need to cast
+ var defaultNamespace =
((DatabricksConnection)Connection).DefaultNamespace;
+ if (defaultNamespace != null) {
+ if (CatalogName == null)
+ {
+ CatalogName = defaultNamespace.CatalogName;
+ }
+ if (SchemaName == null)
+ {
+ SchemaName = defaultNamespace.SchemaName;
Review Comment:
I need to check. The server will not return a default schema by default,
though. So this only affects queries were the user has set the schema. Which
seems reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
